fix(dns): print valid JSON/YAML output for list cmds#1040
Merged
rubenhoenle merged 1 commit intomainfrom Nov 14, 2025
Merged
Conversation
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
marceljk
approved these changes
Nov 13, 2025
2238a6d to
947eb73
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITCLI-266 / #893
Testing
stackit dns zone list-> Expected output:No zones found for project "xxx" matching the criteriastackit dns zone list --output-format json-> expected valid JSON outputstackit dns zone list --output-format yaml-> expected valid YAML outputstackit dns zone create --name my-zone --dns-name www.my-zone.comexport ZONE_ID="xxx"stackit dns zone list-> Expected output: Table showing the available DNS zonesstackit dns zone list --output-format json-> expected valid JSON outputstackit dns zone list --output-format yaml-> expected valid YAML outputstackit dns record-set list --zone-id $ZONE_ID-> Expected output: Table showing the default DNS zone record setsstackit dns record-set list --zone-id $ZONE_ID --output-format json-> expected valid JSON outputstackit dns record-set list --zone-id $ZONE_ID --output-format yaml-> expected valid YAML outputstackit dns zone delete $ZONE_IDChecklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)